upgradeprovision error
Anatoliy Atanasov
anatoliy.atanasov at postpath.com
Fri May 14 04:10:31 MDT 2010
> > On Thu, 2010-05-13 at 15:11 +0300, Anatoliy Atanasov wrote:
> > Hi Andrew,
> >
> > Here are the patches. Please take a look and push if its ok.
>
> It looks OK, except that you should really use a real boolean - true
> and
> false in the python.
>
> Also, I don't like it just being a default value in setup_samdb() - it
> should either be hardcoded lower down, or set up at the provision()
> layer like all the other defaults.
I thought that someday when we make the provision to call vampire this will be re-factored.
Anyway, you are right that this way is better.
I attached them again.
Regards,
Anatoliy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-rodc-Cache-am_rodc-flag.patch
Type: text/x-diff
Size: 2423 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100514/1e70c40c/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s4-rodc-Set-am_rodc-flag-during-provision.patch
Type: text/x-diff
Size: 6822 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100514/1e70c40c/attachment-0001.patch>
More information about the samba-technical
mailing list