Review of brl scaling fix patches.
tridge at samba.org
tridge at samba.org
Fri Feb 5 23:06:21 MST 2010
Hi Jeremy,
> Do these really need to be "static int"'s ?
I had forgotten that you were trying to reduce static vars in s3. I
only used one as lp_parm_int() uses get_parametrics() which is O(N) in
the number of non-fixed parameters. That means we pay a bit extra to
get the param when a child dies. I doubt it would be measurable
though, so it's fine just to init each time of course.
Ideally we'd change loadparm sometime to use a better data structure
for parametric options (such as a sorted list or a tree), although its
probably not urgent.
Cheers, Tridge
More information about the samba-technical
mailing list