replace.h trivial copy/paste error?

Jelmer Vernooij jelmer at samba.org
Thu Aug 19 16:36:10 MDT 2010


On Thu, 2010-08-19 at 17:15 -0500, Michael_E_Brown at Dell.com wrote:
> In tdb 1.2.1, libreplace/replace.h has:
> 
> /* Decimal notation.  */
> #ifndef PRId8
> # define PRId8      "d"
> #endif
> #ifndef PRId16
> # define PRId16     "d"
> #endif
> #ifndef PRId32
> # define PRId32     "d"
> #endif
> #ifndef PRId64
> # define PRId64     __PRI64_PREFIX "d"
> #endif
> 
> #ifndef PRIi8
> # define PRIi8      "i"
> #endif
> #ifndef PRIi8
> # define PRIi16     "i"
> #endif
> #ifndef PRIi8
> # define PRIi32     "i"
> #endif
> #ifndef PRIi8
> # define PRIi64     __PRI64_PREFIX "i"
> #endif
> 
> The second set starts at line 81, and it looks like the #ifndefs were
>  accidentally cut/paste without changing them from PRIi8 to the
>  appropriate type. If this isnt a copy/paste error, it probably should
>  have a comment.
That's indeed unintentional; I'll push a fix to our git repository.
Thanks for letting us know.

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100820/897b8e6a/attachment.pgp>


More information about the samba-technical mailing list