hmm.. Re: talloc issues
Jeremy Allison
jra at samba.org
Tue Jul 28 10:47:00 MDT 2009
On Tue, Jul 28, 2009 at 11:47:35AM -0400, Volker Lendecke wrote:
> So I am not able to do this code audit. To me talloc is
> strictly hierarchical and there is no such thing as "random
> latest parent". Having to think about possible security
> holes or memory leaks by calling talloc_free (How weird is
> that. Creating a memory leak by calling talloc_FREE(!!) in a
> subtly wrong context) makes it unusable to me.
>
> Talloc_reference needs to go. It might be useful in your
> context, but for mere mortals like me this is just not
> acceptable. In projects with more complexity than Samba 3
> has and where all the smart cookies do programming this
> might be common practice, but it is way over my head.
+1. talloc_reference broke my brain a long time ago,
and I don't want to maintain any code that contains
it.
Jeremy.
More information about the samba-technical
mailing list