CTDB 1.0.70 missing header file.

[ronnie sahlberg]

Thanks for that Michael,
Ill merge it once im back from vacation



On Thu, Jan 29, 2009 at 10:04 PM, Michael Adam <ma at sernet.de> wrote:
> Hi William,
>
> Thanks for reporting that error.
> I have reproduced it on our AIX machine.
>
> Your fix works but is not entirely correct
> since it is not portable.
>
> The proper fix is to add "#include "network/system.h"
> (which comes from lib/replace) to include/includes.h
> before ctdb.h is included.
>
> I have pushed the according fix to my ctdb repo
> git://git.samba.org/obnox/ctdb.git , branch master.
> (http://gitweb.samba.org/?p=obnox/ctdb.git;a=shortlog;h=refs/heads/master)
> This is currently at 1.0.70 + a couple of patches.
>
> I have produced a new tarball for testing:
> http://samba.org/~obnox/ctdb/ctdb-1.0.70-obnox.1.tar.gz
>
> I am sure these patches will go upstream soon.
> I am Cc-ing Ronnie Sahlberg, the ctdb maintainer.
>
> Ronnie: More patches :-)
>
> Cheers - Michael
>
> William Jojo wrote:
>>
>> Building ctdb 1.0.70 on AIX 5.3, GCC 4.2.3:
>>
>> Compiling server/ctdbd.c
>> In file included from ./include/includes.h:8,
>>                  from server/ctdbd.c:20:
>> ./include/ctdb.h:532: error: field 'sa' has incomplete type
>> make: *** [server/ctdbd.o] Error 1
>> Return code was 2
>>
>> build-lpp: Failed to make.
>>
>>
>> Patch is the following:
>>
>> --- include/ctdb.h.orig 2009-01-28 08:23:42.000000000 -0500
>> +++ include/ctdb.h      2009-01-28 08:24:14.000000000 -0500
>> @@ -20,6 +20,7 @@
>>  #ifndef _CTDB_H
>>  #define _CTDB_H
>>
>> +#include <sys/socket.h>
>>  #include <netinet/in.h>
>>
>>  #define CTDB_IMMEDIATE_MIGRATION       0x00000001
>>
>>
>> Want to file a bug, but there is no CTDB option on the Bugzilla site.
>>
>>
>> Cheers,
>> Bill
>
> --
> Michael Adam <ma at sernet.de>  <obnox at samba.org>
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9
> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
> http://www.SerNet.DE, mailto: Info @ SerNet.DE
>