[PATCH] Don't send MSG_WINBIND_ONLINE to idmap_child() in any child process

boyang boyang at suse.de
Tue Jan 13 10:31:18 GMT 2009


Stefan (metze) Metzmacher wrote:
> boyang schrieb:
>   
>> Hi, everyone:
>>      If the trusted domain cannot go online, fork_child_dc_connect()
>> will be invoked periodically to fork() one child process, trying to
>> connect to DC.  look, fork_child_dc_connect() ---> getdcs() --->
>> get_dc_name_via_netlogon() ---> cm_connect_netlogon() --->
>> init_dc_connection() ---> cm_open_connection ---> set_domain_online(),
>> here send MSG_WINBIND_ONLINE to idmap_child(). It causes
>> MSG_WINBIND_ONLINE being sent to idmap_child() periodically, which cause
>> idmap child to fork and connect to the primary domain'DC even primary
>> domain is already online. :-)  It is very expensive, we must not want to
>> do that....
>>
>> Please review the patches!
>> Thanks!
>>     
>
> Shouldn't we just don't listen for MSG_WINBIND_ONLINE messages in the
> idmap child?
>   
I think we need it. When network goes from down to up, we can send msg
to parent process, which will forward the msg to all domains and idmap
child.
> metze
>
>   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: boyang.vcf
Type: text/x-vcard
Size: 187 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090113/e0fb128e/boyang-0001.vcf


More information about the samba-technical mailing list