Threading libsmbclient - a proposal.

Jeremy Allison jra at samba.org
Tue Apr 7 23:32:28 GMT 2009


On Tue, Apr 07, 2009 at 04:15:26PM -0700, Howard Chu wrote:
>
> We often find the need for a trylock() op - fail immediately if the lock 
> is in use, instead of waiting.

I thought about that one, but I don't see an immediate need
for it in our code which will be mainly mutex locks around
globals. When *exactly* do you find a use for trylock ?

> Your pthread destroy_lock needs to free() the lock memory that you 
> malloc'd; pthread_mutex_destroy() only deinitializes it, it doesn't 
> actually free it.

Cool - thanks for the bug report. I did that in the tls code
bug missed it in the lock code - fixed.

Jeremy.


More information about the samba-technical mailing list