More fixes needed for 3.2-stable

Jeremy Allison jra at samba.org
Wed May 14 21:16:44 GMT 2008


Karolin, here are some more git-diffs to pull for
3.2 stable.

Thanks !

Jeremy.

One commit for bug: #5464

------------------------------------------------------
commit 6da910cc1c6baccbb143f0b2d347e31e9f84c35b
Author: Jeremy Allison <jra at samba.org>
Date:   Wed May 14 14:11:26 2008 -0700

    Fix bug #5464. Pointed out by Herb @ Connectathon. In fork_domain_child() we call :
    
    CatchChild();
    
    *before* we fork the domain child. This call establishes a signal handler that
    eats SIGCLD signals and doesn't call sys_select_signal() as the main daemon
    SIGCLD handler should do. This causes the parent to ignore dead children and
    time out, instead of calling winbind_child_died() on receipt of the signal. The
    correct fix is to move the CatchChild call into the child code after the fork.
    
    Jeremy.
------------------------------------------------------

Four commits for bug #5460

------------------------------------------------------
commit 5c6ed7774220dea30c2c8a564648406b4f3eacbf
Author: Jeremy Allison <jra at samba.org>
Date:   Tue May 13 14:03:21 2008 -0700

    Fix bug #5460. The problem is RHEL5.0 shipped a CIFS client
    that sets the DFS bit on pathnames but doesn't
    send DFS paths. This causes lookups to fail as
    the smbd/msdfs.c code now just eats the first
    two parts of the pathname and uses the rest as
    the local path. The previous hostname check
    used to protect us from that as we knew that
    when the hostname was invalid it was a local
    path (and a broken client).
    I didn't want to put that check back in, but
    came up with another idea - even though the
    hostname can be a different one, the sharename
    must be valid on this machine. So we can check
    for a valid sharename instead.
    Jeremy.

commit c3328a252430007cd716a406d85fd2a0bbbff607
Author: Jeremy Allison <jra at samba.org>
Date:   Tue May 13 15:02:53 2008 -0700

    Second part of patch for bug #5460. Cope with pathnames
    that don't look like \xxx\yyy, cope with arbitrary length.
    Jeremy.

commit 0a68f230cd92b97efed2b3bad19a3bf9a750d401
Author: Jeremy Allison <jra at samba.org>
Date:   Tue May 13 15:25:14 2008 -0700

    Fix debug message.
    Jeremy.

commit 4d30a6bff9ce8e826f0109e99021d6683ec4299f
Author: Jeremy Allison <jra at samba.org>
Date:   Wed May 14 14:09:02 2008 -0700

    Ensure we don't keep searching for sharename if it's
    not the start of the list.
    Jeremy.

------------------------------------------------------


More information about the samba-technical mailing list