5a270bc99f52483f168d662d843672d05be74473

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Karolin Seeger wrote:
> Jerry,
> 
> I am still going through the revert/merge lists. What about your
> 5a270bc99f52483f168d662d843672d05be74473 (Winbind: Prevent cycle in
> children list when reaping dead child processes.)?
> 
> Should this one be in v3-2-stable? Or reverted in v3-2-test?

Needs to be in v3-2-stable.  It's a nasty bug to reproduce
but here is the summary.

    The parent winbindd process will reap any children
    that are not responding.  As part of killing the stalled
    child, the event handlers for that child are also
    removed.  Internally However we reuse the data
    structure containing information about the domain
    that the defunt child process was handling.
    So when we re-connect the child to the domain, we
    were re-adding the structure to the interal list of
    child processes which resulted in an infinite loop when
    processing messages for childen.

    One reason for the high CPU usage on my laptop was
    transitioning to offline mode.   The parent winbindd
    daemon was stuck in a loop continually trying to tell
    the same child to go offline.

Jeremy was confident enough to sign off on it for the v3-0
branch as well





cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIIcTyIR7qMdg1EfYRAkqYAJ4zDqQbuXzP/ZGXYkcKzF7NxbhYvwCggZQD
nmSe9DbvEtbXpRJhIrNkjfg=
=fS8q
-----END PGP SIGNATURE-----