[SCM] Samba Shared Repository - branch v4-0-test updated - release-4-0-0alpha3-252-gc7f34f4

[Stefan (metze) Metzmacher]

Andrew Bartlett schrieb:
> On Fri, 2008-04-18 at 18:11 -0500, Stefan Metzmacher wrote:
>> The branch, v4-0-test has been updated
>>        via  c7f34f41c3f9f0c3f75a618dfaf566706014a6b4 (commit)
>>       from  8e4f16e975e192709f398c98650cbe9fe2a76261 (commit)
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-0-test
>>
>>
>> - Log -----------------------------------------------------------------
>> commit c7f34f41c3f9f0c3f75a618dfaf566706014a6b4
>> Author: Stefan Metzmacher <metze at samba.org>
>> Date:   Fri Apr 18 22:20:49 2008 +0200
>>
>>     build: fix the build rule for .o files
>>     
>>     metze
>>
>> -----------------------------------------------------------------------
>>
>> Summary of changes:
>>  source/build/make/rules.mk |    4 +++-
>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source/build/make/rules.mk b/source/build/make/rules.mk
>> index faefb4e..541fa01 100644
>> --- a/source/build/make/rules.mk
>> +++ b/source/build/make/rules.mk
>> @@ -211,7 +211,9 @@ include/includes.d: include/includes.h
>>  	@echo "Compiling $<"
>>  	@-mkdir -p `dirname $@`
>>  	@$(COMPILE) && exit 0 ; \
>> -	$(COMPILE) 
>> +		echo "The following command failed:" 1>&2;\
>> +		echo "$(COMPILE)" 1>&2;\
>> +		$(COMPILE) >/dev/null 2>&1
> 
> I'm still lost as to why we need to compile it twice.  What am I
> missing?

We need to return the error code of the compile run to 'make'
And if I remember correctly this was the only portable way,

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20080502/3e90c3bc/signature.bin