Samba 4 and IPv6

[Andrew Bartlett]

On Tue, 2008-04-29 at 08:36 +0200, tridge at samba.org wrote:
> Hi Andrew,
> 
>  > Could you please post lib/util/util_ip.[ch]?  If you could post just
>  > those 2 files separately, I could easily pull them into what I have
>  > already merged with your original patch.
> 
> ahh, darn, sorry.
> 
> I've put the patch with the util_ip.[ch] files up at
> http://samba.org/~tridge/s4_ipv6.patch
> 
> I'm flying back to Australia today, so I will be off the air for a day
> or so.

The tests in gensec_gssapi and gensec_krb5:


--- a/source/auth/gensec/gensec_gssapi.c
+++ b/source/auth/gensec/gensec_gssapi.c
@@ -318,7 +318,7 @@ static NTSTATUS gensec_gssapi_client_start(struct gensec_security *gensec_securi
 		DEBUG(1, ("Could not determine hostname for target computer, cannot use kerberos\n"));
 		return NT_STATUS_INVALID_PARAMETER;
 	}
-	if (is_ipaddress(hostname)) {
+	if (is_ipv4address(hostname)) {
 		DEBUG(2, ("Cannot do GSSAPI to an IP address\n"));
 		return NT_STATUS_INVALID_PARAMETER;
 	}

Need to be changed back to 'is_ipaddress', which must determine if it is
any form of address, or be inverted to a 'is name' of some kind.  Even
the magic of IPv6 can't make this suitable for kerberos :-)

Andrew Bartlett
-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20080430/c7b029ff/attachment.bin