Convert unlink_internals to use delete_on_close?

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Jan 4 20:51:58 GMT 2007


Hi, Jeremy!

Right now I'm trying to streamline unlink_internals a bit.
One way to do it correctly and a bit less racy would be to
got through the full ntcreate, set_delete_on_close, close
cycle.

Speed-wise it should not make too much of a difference
because in can_delete we go through ntcreate/close anyway.
A necessary change would be to have close_file() actually
return NTSTATUS (Hey, we have to take care of the return
status of close(2) ;-)) to correctly report
NT_STATUS_ACCESS_DENIED for example.

What do you think? It potentially removes some of the code
in reply.c.

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20070104/d92302fb/attachment.bin


More information about the samba-technical mailing list