mod_auth_ntlm_winbind build

[Andrew Bartlett]

On Fri, 2007-02-09 at 08:27 +0100, Stefan Gohmann wrote:
> Hello,
> 
> I've tried to build the mod_auth_ntlm_winbind debian package from 
> http://mirrors.bevc.net/samba/ftp/unpacked/lorikeet/mod_auth_ntlm_winbind/.
> 
> First the build fails, because the configure script was missing:
> 
> dpkg-buildpackage -rfakeroot
> [...]
> make: [build-apache13] Error 2 (ignored)
> ./configure --with-apxs=/usr/bin/apxs
> make: ./configure: Command not found
> make: *** [build-apache13] Error 127
> 
> After adding autoconf to the build dependency and call autoconf before 
> starting the configure script in debian/rules it works.
> 
> It seems that the PROXYREQ_PROXY is only in apache2 defined:

Drat!  We really need an apache1 and apache2 host in the build farm, and
to have this automatically tested.

> make[1]: Entering directory `/home/stegoh/mod_auth_ntlm_winbind'
> /usr/bin/apxs  -Wc,-Wall -c mod_auth_ntlm_winbind.c
> gcc -DLINUX=22 -DEAPI -DTARGET="apache" -DHAVE_SET_DUMPABLE -DDB_DBM_HSEARCH=1 -DDEV_RANDOM=/dev/random -DUSE_HSREGEX -O1  -g -Wall -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -fPIC -DSHARED_MODULE -I/usr/include/apache-1.3 -Wall  -c 
> mod_auth_ntlm_winbind.c
> mod_auth_ntlm_winbind.c: In function 'note_auth_failure':
> mod_auth_ntlm_winbind.c:322: error: 'PROXYREQ_PROXY' undeclared (first use in 
> this function)
> mod_auth_ntlm_winbind.c:322: error: (Each undeclared identifier is reported 
> only once
> mod_auth_ntlm_winbind.c:322: error: for each function it appears in.)
> mod_auth_ntlm_winbind.c: In function 'get_auth_header':
> mod_auth_ntlm_winbind.c:359: error: 'PROXYREQ_PROXY' undeclared (first use in 
> this function)
> mod_auth_ntlm_winbind.c: In function 'send_auth_reply':
> mod_auth_ntlm_winbind.c:414: error: 'PROXYREQ_PROXY' undeclared (first use in 
> this function)
> mod_auth_ntlm_winbind.c: In function 'process_msg':
> mod_auth_ntlm_winbind.c:843: error: 'PROXYREQ_PROXY' undeclared (first use in 
> this function)
> mod_auth_ntlm_winbind.c: In function 'check_user_id':
> mod_auth_ntlm_winbind.c:948: error: 'PROXYREQ_PROXY' undeclared (first use in 
> this function)
> apxs:Break: Command failed with rc=1
> 
> For me, an ifdef statement works, see the attached patch.

On apache1, is r->proxyreq a boolean?  Could we do 

#define PROXYREQ_PROXY true 
(or similar)

Also, we really should fix the order to be r->proxyreq ==
PROXYREQ_PROXY.  I was lazy when I committed the contributed patch, and
it shows here.  We need a mod_ntlm_winbindd maintainer (or I need to
defer to them, if someone else has actually taken up the reigns, and
I've missed it...).

Andrew Bartlett
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.                  http://redhat.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20070209/6d9515e6/attachment.bin