[SAMBA4][PATCH] don't try to resolv ipaddr-strings into an ip-address

tridge at samba.org tridge at samba.org
Tue Sep 13 00:43:51 GMT 2005


Metze,

I forgot to mention the other reason this doesn't work. In the patch
below the code checks for c->async.fn() but that won't be setup yet,
as the caller hasn't yet seen the composite context 'c', so can't have
filled it in.

I'm testing a composite_trigger_done() function at the moment, and
will post it for you to look at shortly.

 > +	if (is_ipaddress(state->name.name)) {
 > +		state->reply_addr = talloc_strdup(state, state->name.name);
 > +		if (!state->reply_addr) goto failed;
 > +		c->state = SMBCLI_REQUEST_DONE;
 > +		if (c->async.fn) {
 > +			c->async.fn(c);
 > +		}
 > +		return c;
 > +	}



More information about the samba-technical mailing list