svn commit: samba r5981 - in branches/SAMBA_3_0/source/libsmb: .

Gerald (Jerry) Carter jerry at samba.org
Wed Mar 23 15:05:41 GMT 2005


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Gerald (Jerry) Carter wrote:
| jra at samba.org wrote:
| | Author: jra
| | Date: 2005-03-22 23:45:57 +0000 (Tue, 22 Mar 2005)
| | New Revision: 5981
| |
| | WebSVN:
| http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=5981
| |
| | Log:
| | Hack to fix DFS code to work with Win98 server. JERRY PLEASE REVIEW
| THIS !
| | I don't think this is correct - it just happens to work and fix bug
#2530
| | to return all the files.
|
| Jeremy,
|
| This one is confusing.  A WIn98 server cannot be a dfs root.  So
| the cli_state->dfsroot flag should never be set.  We should have
| never reached the cli_dfs_check_error() call.  Do you have any
| traces with the error?

Never mind.  I'm an idiot.  The tcon&X reply from win9x has a
wct of 2.  Win2k includes an additional 16 bit optional support
field that includes whether or not this is a dfs root share.

The real fix is to set the dfsroot flag correctly in cli_send_tconX.
I'll fix this up now.  Should have the same effect as your change.






cheers, jerry
=====================================================================
Alleviating the pain of Windows(tm)      ------- http://www.samba.org
GnuPG Key                ----- http://www.plainjoe.org/gpg_public.asc
"I never saved anything for the swim back."     Ethan Hawk in Gattaca
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCQYXFIR7qMdg1EfYRArCdAJ402fBfATZC4dkIhuGD6v+q/XcGWACgyKY3
vT29RGbZ2+rUnvFtqf8cauw=
=SlBK
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list