nbt bug?

Stefan (metze) Metzmacher metze at samba.org
Sat Jan 22 19:49:54 GMT 2005


> Metze,
>
>  > I think to reset the name_trn_id when we store it under an other id in
> the idr-tree
>  > otherwise the reply couldn't be matches correctly.
>
> well spotted!
>
> There was actually a 2nd bug in that same code too. It should have
> done:
>
>  req->request->name_trn_id = id;
>
> after getting the id from the idtree. Otherwise if it ever doesn't get
> the first id it asks for then it will fail in the same way.
>
> Thanks very much for reviewing this code.

there's also another bug,

I think you need blob.length = nread;

after the socket_recvfrom(), this but isn't noticed because the idl code
has the NDR_REMAINING



--
metze

Stefan Metzmacher <metze at samba dot org>


More information about the samba-technical mailing list