composite rpc call

Rafal Szczesniak mimir at samba.org
Tue Feb 22 11:17:52 GMT 2005


On Tue, Feb 22, 2005 at 11:55:27AM +0100, Rafal Szczesniak wrote:
> On Tue, Feb 22, 2005 at 02:00:10PM +1100, Andrew Tridgell wrote:
> > Mimir,
> > 
> >  > Could you please take a look at source/libnet/userinfo.c file and tell
> >  > me what is coded incorrectly. I haven't tested it yet, so almost
> >  > certainly something is broken, but you surely have some opinion on
> >  > that code just by looking.
> > 
> > I hope you don't mind me replying publicly. I thought that others
> > might find the answers interesting.
> 
> Of course. It has some educational valor for potential samba hackers.

ugh... s/valor/value/

> > (3)
> > Lines like this:
> >   memcpy((void*)r.in.user_handle, (void*)rep->out.user_handle, sizeof(struct policy_handle));
> > should be replaced with this:
> >   r.in.user_handle = rep->out.user_handle;

One more question: Is there a function I could use to copy a policy
handle structure ? In case I don't want to get the pointer, I need to
copy it and I couldn't find such a function. Needs to be coded ? :)


cheers,
-- 
Rafal Szczesniak
Samba Team member  http://www.samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20050222/f3c01792/attachment.bin


More information about the samba-technical mailing list