Patch for printers browser, samba3.0.2pre1

Andrew Bartlett abartlet at samba.org
Sat Jan 31 21:15:55 GMT 2004


On Sun, 2004-02-01 at 05:24, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Jianliang Lu wrote:
> | This patch will solve the problem of printers listing when you use the
> add
> | printer wizard to add a samba shared printer to your windows workstation.
> |
> | Cheers,
> | Jianliang Lu
> |
> | patch:
> |
> | --- samba-3.0.2pre1/source/param/loadparm.c.orig    Fri Jan 16
> 09:30:51 2004
> | +++ samba-3.0.2pre1/source/param/loadparm.c Fri Jan 16 09:39:46 2004
> | @@ -4094,6 +4094,7 @@
> |     default_server_announce |= SV_TYPE_WORKSTATION;
> |     default_server_announce |= SV_TYPE_SERVER;
> |     default_server_announce |= SV_TYPE_SERVER_UNIX;
> | +   default_server_announce |= SV_TYPE_PRINTQ_SERVER;
> |
> |     switch (lp_announce_as()) {
> 
> Added for 3.0.2rc2.  Thanks.

It didn't work (or later broke) but I remember when tpot removed this,
and added:

/***************************************************************************
 Announce ourselves as a print server.
***************************************************************************/

void update_server_announce_as_printserver(void)
{
	default_server_announce |= SV_TYPE_PRINTQ_SERVER;	
}

To only display this flag when we are actually serving printers.  

The problem is, as I read the code it should have worked...

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20040201/471d424f/attachment.bin


More information about the samba-technical mailing list