nmbd error when server name has 15 characters

[Christopher R. Hertel]

Ouch.

Which version of Samba are you testing against?

Chris -)-----

Matt Seitz wrote:
> 
> The nmbd daemon reports an error when starting up if the netbios name is exactly
> 15 characters long.  The problem appears to be in the send_announcement function
> in src/ext/samba/source/nmbd/nmbd_sendannounce.c.  Line 106 reads:
> 
>      push_string(NULL, p+5, server_name, 15, STR_ASCII|STR_UPPER|STR_TERMINATE);
> 
> The STR_TERMINATE flag adds one to the server_name length, making it greater
> than maximum destination length of 15.  I'm not sure whether the correct fix is
> to increase the destination length or remove the STR_TERMINATE flag.

-- 
"Implementing CIFS - the Common Internet FileSystem" ISBN: 013047116X
Samba Team -- http://www.samba.org/     -)-----   Christopher R. Hertel
jCIFS Team -- http://jcifs.samba.org/   -)-----   ubiqx development, uninq.
ubiqx Team -- http://www.ubiqx.org/     -)-----   crh at ubiqx.mn.org
OnLineBook -- http://ubiqx.org/cifs/    -)-----   crh at ubiqx.org