[patch 2/3] whitespace cleanups in fs/cifs/file.c

Jörn Engel joern at wohnheim.fh-wedel.de
Wed Dec 29 12:10:33 GMT 2004


On Wed, 29 December 2004 10:51:30 +0100, Wichert Akkerman wrote:
> Previously Jörn Engel wrote:
> > On Wed, 29 December 2004 00:52:32 +0100, Jesper Juhl wrote:
> > > -static int cifs_relock_file(struct cifsFileInfo * cifsFile)
> > > +static int 
> > > +cifs_relock_file(struct cifsFileInfo *cifsFile)
> > 
> > Linus viciously prefers to keep return type and function name on a
> > single line.  I cannot quite follow his reasoning, but would leave
> > that part out, unless explicitly requested by Steve.
> 
> If they are on a single line grep will find the return type as well
> which is extremely convenient.

Ok, that reasoning I can follow.  Thanks, Wichert!

Jörn

-- 
Anything that can go wrong, will.
-- Finagle's Law


More information about the samba-technical mailing list