[PATCH] Clean up cli_pipe to find the auth footer once only.

[Ronan Waide]

On July 16, abartlet at samba.org said:
> 
> Thankyou very much for finding this - my test domain didn't seem to give
> me the fragmentated PDUs.
 

Did someone mention fragmented PDUs?
https://bugzilla.samba.org/show_bug.cgi?id=68

I'm kinda curious if anyone aside from me has hit this problem. I've
attached an updated patch, in case anyone wants to play with it.

Waider.

Index: source/include/rpc_dce.h
===================================================================
RCS file: /cvsroot/samba/source/include/rpc_dce.h,v
retrieving revision 1.22.2.8
diff -u -r1.22.2.8 rpc_dce.h
--- source/include/rpc_dce.h    14 Jul 2003 08:46:31 -0000      1.22.2.8
+++ source/include/rpc_dce.h    16 Jul 2003 08:46:37 -0000
@@ -78,7 +78,8 @@
 #define AUTH_PIPE_NETSEC  0x0008
 
 /* Maximum PDU fragment size. */
-#define MAX_PDU_FRAG_LEN 0x1630
+/* #define MAX_PDU_FRAG_LEN 0x1630 */
+#define MAX_PDU_FRAG_LEN 0x10b8
 /* #define MAX_PDU_FRAG_LEN 0x10b8             this is what w2k sets */
 
 /*
Index: source/libsmb/clireadwrite.c
===================================================================
RCS file: /cvsroot/samba/source/libsmb/clireadwrite.c,v
retrieving revision 1.16.2.7
diff -u -r1.16.2.7 clireadwrite.c
--- source/libsmb/clireadwrite.c        15 Jan 2003 18:57:39 -0000      1.16.2.7
+++ source/libsmb/clireadwrite.c        16 Jul 2003 08:46:37 -0000
@@ -326,7 +326,7 @@
        int issued = 0;
        int received = 0;
        int mpx = MAX(cli->max_mux-1, 1);
-       int block = (cli->max_xmit - (smb_size+32)) & ~1023;
+       int block = cli->max_xmit - (smb_size+32);
        int blocks = (size + (block-1)) / block;
 
        while (received < blocks) {

-- 
waider at waider.ie / Yes, it /is/ very personal of me.

kludge says, "I need a bible quote which supports wiring XLR connectors pin-3
    hot."