[PATCH] move all smb_register_*() to NTSTATUS

[Jelmer Vernooij]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 28 April 2003 07:44, Stefan Metzmacher wrote:
> At 04:00 28.04.2003 +0200, Jelmer Vernooij wrote:
> >On Sat, Apr 26, 2003 at 03:31:25PM +0200, Stefan (metze) Metzmacher wrote
> >
> >about '[PATCH] move all smb_register_*() to NTSTATUS':
> > > Hi Jelmer,
> > >
> > > I have merged in you last changes....
> > >
> > > here's the patch that converts all smb_register_*() fn's to return
> > > NTSTATUS
> > >
> > > also I have introduced a SMB_RPC_INTERFACE_VERSION
> > >
> > > and all smb_register_*() fn's have uint16 version as the FIRST
> > > parameter now.
> > >
> > > so will not get pain if we want to change the parameter count of such a
> > > function.
> > >
> > > smb_register_charset() is the only function witch have no uint16
> > > version...
> >I've looked at this patch and it looks (overall) nice! I'm going to
> >commit it after I've done a few tests later today, except for the
> >info_struct stuff. That's not complete and I'm not really sure whether
> >we want to have that in 3.0 already. Everything depends on everything
> >so I'm not sure whether we can have that working correctly with the
> >current architecture of samba..
> ok, drop the info_struct stuff if you like...
I'm making some more modifications:

- - changing NT_STATUS_INVALID_INFO_LEVEL -> NT_STATUS_OBJECT_TYPE_MISMATCH
- - not updating any version numbers. We change the order of the arguments to
  the register function so we break with previous modules anyway.
- - Some minor other changes (typos, etc)

Please keep your patches small, for example for this patch, one patch per 
subsystem. That makes it easier for us to review and test them so I can apply 
your patches sooner. 

Jelmer
- -- 
Jelmer Vernooij                                      <jelmer at samba.org>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+rVQJPa9Uoh7vUnYRAlLnAKCINdgqCrYnLfQSZlj9KwRDUhs7gACgk32N
cJAWB/2taRMa5NP/i+ayXBc=
=LvPc
-----END PGP SIGNATURE-----