CVS update: samba/source/param

Andrew Bartlett abartlet at samba.org
Thu Apr 24 03:39:47 GMT 2003


On Thu, 2003-04-24 at 07:00, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 24 Apr 2003, Andrew Bartlett wrote:
> 
> > I noticed *SMBSERVER being subed into a %L macro.
> > 
> > For most of samba, we want %L to return our netbios name, if the client
> > didn't tell us 'our name'.
> > 
> > However, it looked like the printing code was trying to use the IP
> > address instead - calling a slightly different function - for some of
> > the return values.  So, that's why I have left the slightly different
> > functions for this.  They probably should be in the same file...
> 
> Originally we would blindly write the global_myname() string 
> into the RPC replies in the spoolss code.  This caused our 
> testers a lot of problems when the windows client was using 
> an IP address instead of a name.  This also made the printing code work 
> with netbios aliases I think.
> 
> Hmmm...now that I think about it, %L should be the netbios name
> used by the client so I think *SMBSERVER (or *SMBSERV) is what 
> it should have been.  In this case, I'm not sure your change 
> was the right thing to do.  Do you follow me ?

On principal that sounds right - but do you really want a profile path
of:

\\_SMBSERVER\profile\abartlet

(That's post alpha-strcpy munging, btw).  I figured I didn't want that,
so hence the change :-)

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20030424/f9dfafdb/attachment.bin


More information about the samba-technical mailing list