smbtorture LOCK1 test on HPUX

[Aruna Prabakar]

Hi,

	Samba Smbtorture LOCK1 test on HPUX failed even after disabling
MMAP. It was failing in tdb_write with an error in log files (Bad File
Number). During investigation we found out that in this section of code in
tdb.c if it is TDB_INTERNAL after tdb->map_ptr was realloced tdb_mmap(tdb)
which makes tdb->map_ptr=NULL was excecuted which is incorrect. So we put a
else statement so that tdb_mmap(tdb) gets excecuted only if it is not
TDB_INTERNAL.
       
LOCK1 Test passes with this Fix.

if (tdb->flags & TDB_INTERNAL)
                tdb->map_ptr = realloc(tdb->map_ptr, tdb->map_size);
        else
        {
            /*
             *     We must ensure the file is remapped before adding the
space
             * to     ensure consistency with systems like OpenBSD where
             * writes and mmaps are not consistent.
             */

            /* We're ok if the mmap fails as we'll fallback to read/write */
            tdb_mmap(tdb);
        }

Best Regards
Aruna 

Full Name:	Aruna Prabakar
Job Title:	Software Engineer
Company:	HP
E-mail:	aruna_prabakar at hp.com







-------------- next part --------------
A non-text attachment was scrubbed...
Name: winmail.dat
Type: application/ms-tnef
Size: 2232 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20010802/89c400e6/winmail.bin