svn commit: samba r14270 - in branches/SAMBA_3_0/source/nsswitch: .
jra at samba.org
jra at samba.org
Mon Mar 13 00:30:19 GMT 2006
Author: jra
Date: 2006-03-13 00:30:18 +0000 (Mon, 13 Mar 2006)
New Revision: 14270
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14270
Log:
Fix coverity #203. Ensure we free on error exit.
Jeremy.
Modified:
branches/SAMBA_3_0/source/nsswitch/winbindd_group.c
Changeset:
Modified: branches/SAMBA_3_0/source/nsswitch/winbindd_group.c
===================================================================
--- branches/SAMBA_3_0/source/nsswitch/winbindd_group.c 2006-03-13 00:26:42 UTC (rev 14269)
+++ branches/SAMBA_3_0/source/nsswitch/winbindd_group.c 2006-03-13 00:30:18 UTC (rev 14270)
@@ -827,8 +827,6 @@
[group_list_ndx * sizeof(struct winbindd_gr)],
gr_mem_list, gr_mem_list_len);
- SAFE_FREE(gr_mem_list);
-
state->response.length += gr_mem_list_len;
DEBUG(10, ("returning %d groups, length = %d\n",
@@ -838,6 +836,8 @@
done:
+ SAFE_FREE(gr_mem_list);
+
if (group_list_ndx > 0)
request_ok(state);
else
More information about the samba-cvs
mailing list