svn commit: samba r14233 - branches/SAMBA_3_0/source/rpc_server
trunk/source/rpc_server
vlendec at samba.org
vlendec at samba.org
Sun Mar 12 10:47:04 GMT 2006
Author: vlendec
Date: 2006-03-12 10:47:02 +0000 (Sun, 12 Mar 2006)
New Revision: 14233
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14233
Log:
Fix Coverity bug # 206
Modified:
branches/SAMBA_3_0/source/rpc_server/srv_spoolss_nt.c
trunk/source/rpc_server/srv_spoolss_nt.c
Changeset:
Modified: branches/SAMBA_3_0/source/rpc_server/srv_spoolss_nt.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_server/srv_spoolss_nt.c 2006-03-12 10:44:19 UTC (rev 14232)
+++ branches/SAMBA_3_0/source/rpc_server/srv_spoolss_nt.c 2006-03-12 10:47:02 UTC (rev 14233)
@@ -4823,8 +4823,10 @@
if((printer=SMB_MALLOC_P(PRINTER_INFO_4))==NULL)
return WERR_NOMEM;
- if (!construct_printer_info_4(print_hnd, printer, snum))
+ if (!construct_printer_info_4(print_hnd, printer, snum)) {
+ SAFE_FREE(printer);
return WERR_NOMEM;
+ }
/* check the required size. */
*needed += spoolss_size_printer_info_4(printer);
Modified: trunk/source/rpc_server/srv_spoolss_nt.c
===================================================================
--- trunk/source/rpc_server/srv_spoolss_nt.c 2006-03-12 10:44:19 UTC (rev 14232)
+++ trunk/source/rpc_server/srv_spoolss_nt.c 2006-03-12 10:47:02 UTC (rev 14233)
@@ -4823,8 +4823,10 @@
if((printer=SMB_MALLOC_P(PRINTER_INFO_4))==NULL)
return WERR_NOMEM;
- if (!construct_printer_info_4(print_hnd, printer, snum))
+ if (!construct_printer_info_4(print_hnd, printer, snum)) {
+ SAFE_FREE(printer);
return WERR_NOMEM;
+ }
/* check the required size. */
*needed += spoolss_size_printer_info_4(printer);
More information about the samba-cvs
mailing list