svn commit: samba r14228 - branches/SAMBA_3_0/source/rpc_parse trunk/source/rpc_parse

vlendec at samba.org vlendec at samba.org
Sun Mar 12 00:08:16 GMT 2006


Author: vlendec
Date: 2006-03-12 00:08:12 +0000 (Sun, 12 Mar 2006)
New Revision: 14228

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14228

Log:
Fix Coverity bug # 217
Modified:
   branches/SAMBA_3_0/source/rpc_parse/parse_spoolss.c
   trunk/source/rpc_parse/parse_spoolss.c


Changeset:
Modified: branches/SAMBA_3_0/source/rpc_parse/parse_spoolss.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_parse/parse_spoolss.c	2006-03-12 00:04:27 UTC (rev 14227)
+++ branches/SAMBA_3_0/source/rpc_parse/parse_spoolss.c	2006-03-12 00:08:12 UTC (rev 14228)
@@ -5071,7 +5071,7 @@
 	q_u->level = level;
 	
 	q_u->info.level = level;
-	q_u->info.ptr = (info!=NULL)?1:0;
+	q_u->info.ptr = 1;	/* Info is != NULL, see above */
 	switch (level)
 	{
 	/* info level 3 is supported by Windows 95/98, WinNT and Win2k */

Modified: trunk/source/rpc_parse/parse_spoolss.c
===================================================================
--- trunk/source/rpc_parse/parse_spoolss.c	2006-03-12 00:04:27 UTC (rev 14227)
+++ trunk/source/rpc_parse/parse_spoolss.c	2006-03-12 00:08:12 UTC (rev 14228)
@@ -5071,7 +5071,7 @@
 	q_u->level = level;
 	
 	q_u->info.level = level;
-	q_u->info.ptr = (info!=NULL)?1:0;
+	q_u->info.ptr = 1;	/* Info is != NULL, see above */
 	switch (level)
 	{
 	/* info level 3 is supported by Windows 95/98, WinNT and Win2k */



More information about the samba-cvs mailing list