svn commit: samba r14020 - in branches/SAMBA_3_0/source/lib: .

[jra at samba.org]

Author: jra
Date: 2006-03-08 06:36:40 +0000 (Wed, 08 Mar 2006)
New Revision: 14020

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14020

Log:
Coverity bug CID #66. Missing free on error exit.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/lib/xfile.c


Changeset:
Modified: branches/SAMBA_3_0/source/lib/xfile.c
===================================================================
--- branches/SAMBA_3_0/source/lib/xfile.c	2006-03-08 06:32:36 UTC (rev 14019)
+++ branches/SAMBA_3_0/source/lib/xfile.c	2006-03-08 06:36:40 UTC (rev 14020)
@@ -96,13 +96,16 @@
 	XFILE *ret;
 
 	ret = SMB_MALLOC_P(XFILE);
-	if (!ret) return NULL;
+	if (!ret) {
+		return NULL;
+	}
 
 	memset(ret, 0, sizeof(XFILE));
 
 	if ((flags & O_ACCMODE) == O_RDWR) {
 		/* we don't support RDWR in XFILE - use file 
 		   descriptors instead */
+		SAFE_FREE(ret);
 		errno = EINVAL;
 		return NULL;
 	}