svn commit: samba r4680 - in
branches/SAMBA_4_0/source/rpc_server/samr: .
abartlet at samba.org
abartlet at samba.org
Tue Jan 11 13:59:18 GMT 2005
Author: abartlet
Date: 2005-01-11 13:59:18 +0000 (Tue, 11 Jan 2005)
New Revision: 4680
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=4680
Log:
Make more efficient use of memory in SAMR:
Avoid a strdup, use a talloc_reference
Use the shortest term memory context possible
Andrew Bartlett
Modified:
branches/SAMBA_4_0/source/rpc_server/samr/dcesrv_samr.c
Changeset:
Modified: branches/SAMBA_4_0/source/rpc_server/samr/dcesrv_samr.c
===================================================================
--- branches/SAMBA_4_0/source/rpc_server/samr/dcesrv_samr.c 2005-01-11 13:55:45 UTC (rev 4679)
+++ branches/SAMBA_4_0/source/rpc_server/samr/dcesrv_samr.c 2005-01-11 13:59:18 UTC (rev 4680)
@@ -2391,7 +2391,7 @@
return NT_STATUS_INTERNAL_DB_CORRUPTION;
}
- a_state = talloc_p(d_state, struct samr_account_state);
+ a_state = talloc_p(mem_ctx, struct samr_account_state);
if (!a_state) {
return NT_STATUS_NO_MEMORY;
}
@@ -2649,7 +2649,7 @@
return NT_STATUS_NO_MEMORY;
}
- msg->dn = talloc_strdup(mem_ctx, a_state->account_dn);
+ msg->dn = talloc_reference(mem_ctx, a_state->account_dn);
if (!msg->dn) {
return NT_STATUS_NO_MEMORY;
}
More information about the samba-cvs
mailing list