OSX and HFS+ filesystem compression

[Mike Bombich]

Hi Robert:

	My apologies, that "if (fnamecmp)" should be commented out as you discovered.  Did you read the updated man page to see the new arguments available for supporting HFS+ compression?  It isn't on by default, you need to use --protect-decmpfs, for example, to preserve those xattrs.

I crafted a new diff and tested it again against 3.0.6.  These steps work for me:

cd ~/Desktop
curl -O http://rsync.samba.org/ftp/rsync/src/rsync-3.0.6.tar.gz
tar -xzvf rsync-3.0.6.tar.gz
rm rsync-3.0.6.tar.gz
curl -O http://rsync.samba.org/ftp/rsync/src/rsync-patches-3.0.6.tar.gz
tar -xzvf rsync-patches-3.0.6.tar.gz
rm rsync-patches-3.0.6.tar.gz
cd rsync-3.0.6

patch -p1 < patches/fileflags.diff
patch -p1 < patches/crtimes.diff
patch -p1 < (path to the attached file)
echo "#define EXTRA_ROUNDING 0" > rounding.h

./prepare-source
./configure
make

sudo ./rsync -aHANXx --force-change --protect-decmpfs --fileflags /Volumes/Source/ /Volumes/Target/

sudo bbouncer verify -d /Volumes/Source /Volumes/Target

Verifying:      hfs-compression ... 
   Sub-test:        decmpfs xattr ... preserved
   Sub-test:   UF_COMPRESSED flag ... set
   Sub-test:        file contents ... match
   Sub-test:        creation time ... ok
   Sub-test:    modification time ... ok
   Sub-test:      hard link inode ... ok
   Sub-test: hard link decmpfs xattr ... preserved
   Sub-test: hard link UF_COMPRESSED flag ... set
   Sub-test: hard link modification time ... ok
ok 
Verifying: hfs-compression_large ... 
   Sub-test:        decmpfs xattr ... preserved
   Sub-test:   UF_COMPRESSED flag ... set
   Sub-test:        file contents ... match
   Sub-test:        creation time ... ok
   Sub-test:    modification time ... ok
   Sub-test:      hard link inode ... ok
   Sub-test: hard link decmpfs xattr ... preserved
   Sub-test: hard link UF_COMPRESSED flag ... set
   Sub-test: hard link modification time ... ok
ok 



Mike




On May 18, 2010, at 10:04 PM, Robert DuToit wrote:

> Hi Mike,
> 
> I guess I did something wrong or removing that line 283 in proto.h was critical
> 
> I ran fileflags and crtimes patches first and then rsync_3.0.6-hfs-compression_20091027.diff but the test shows no go. 
> 
> Sub-test: decmpfs xattr ... not preserved
> Sub-test: UF_COMPRESSED flag ... not set
> 
> Thanks, rob

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.samba.org/pipermail/rsync/attachments/20100519/6f86edf1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rsync_3.0.6-hfs-compression_20091027.diff
Type: application/octet-stream
Size: 33099 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/rsync/attachments/20100519/6f86edf1/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.samba.org/pipermail/rsync/attachments/20100519/6f86edf1/attachment-0001.html>