DO NOT REPLY [Bug 5802] New: misleading error message in atomic rsync

samba-bugs at samba.org samba-bugs at samba.org
Mon Sep 29 22:35:01 GMT 2008


https://bugzilla.samba.org/show_bug.cgi?id=5802

           Summary: misleading error message in atomic rsync
           Product: rsync
           Version: 3.1.0
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: trivial
          Priority: P3
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: normalperson at yhbt.net
         QAContact: rsync-qa at samba.org


When renaming $dest_dir to $old_dir, don't say we're renaming
$new_dir to $old_dir on errors.

--- a/atomic-rsync
+++ b/atomic-rsync
@@ -48,7 +48,7 @@ if (system($RSYNC_PROG, "--link-dest=$dest_dir", @ARGV)) {
     exit $?;
 }

-rename($dest_dir, $old_dir) or die "Unable to rename $new_dir to $old_dir:
$!";
+rename($dest_dir, $old_dir) or die "Unable to rename $dest_dir to $old_dir:
$!"
 rename($new_dir, $dest_dir) or die "Unable to rename $new_dir to $dest_dir:
$!"

 exit;


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


More information about the rsync mailing list