Warnings compiling rsync on Panther

Vitorio Machado v.machado at permanence-informatique.fr
Thu Feb 21 20:43:38 GMT 2008


There are some warnings on uidlist compiling rsync under 10.3:

gcc -std=gnu99 -I. -I. -g -O2 -DHAVE_CONFIG_H -Wall -W -I./popt  -c 
uidlist.c -o uidlist.o
uidlist.c: In function `match_uid':
uidlist.c:210: warning: comparison between signed and unsigned
uidlist.c: In function `match_gid':
uidlist.c:222: warning: comparison between signed and unsigned
uidlist.c:226: warning: comparison between signed and unsigned
uidlist.c: In function `add_uid':
uidlist.c:249: warning: comparison between signed and unsigned
uidlist.c: In function `add_gid':
uidlist.c:267: warning: comparison between signed and unsigned

On rsync.h line 414 we have:

#ifndef HAVE_ID_T
typedef int id_t;

On mac types.h line 106 we have:
typedef	u_int32_t	uid_t;		/* user id */

Would it break things on other systems to change id_t from int to 
unsigned int?
If no, can we change this type?
If yes, can we have a 10.3 flag
#ifdef PANTHER
typedef unsigned int id_t;
#else
typedef int id_t;
?

Vitorio
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/enriched
Size: 1452 bytes
Desc: not available
Url : http://lists.samba.org/archive/rsync/attachments/20080221/d1b8395d/attachment.bin


More information about the rsync mailing list