DO NOT REPLY [Bug 5051] --copy-dest copies should use a temporary file unless --inplace

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=5051





------- Comment #1 from matt at mattmccutchen.net  2007-10-28 00:19 CST -------
Created an attachment (id=2956)
 --> (https://bugzilla.samba.org/attachment.cgi?id=2956&action=view)
Attempt to implement temporary file usage, etc.

In this patch I did the following:
- Factored out temporary file creation code from recv_files -> open_tmpfile
- Took the opportunity to reduce code duplication in recv_files
- Added an argument to copy_file to make it write to an existing fd instead of
opening its own; updated existing calls
- Wrote new logic for local copies in do_local_copy, using open_tmpfile and the
new copy_file mode when !inplace
- Took the opportunity to implement cleanup for partially written local-copy
targets

This patch is a first draft; it seems to work, but it could probably use
further testing and cleanup.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.