DO NOT REPLY [Bug 3692] regression: symlinks are created as hardlinks with --link-dest

samba-bugs at samba.org samba-bugs at samba.org
Mon Apr 17 07:41:18 GMT 2006


https://bugzilla.samba.org/show_bug.cgi?id=3692





------- Comment #1 from noreply at cpe-24-95-90-2.columbus.res.rr.com  2006-04-17 02:41 MST -------
try this...

seems at least freebsd, possibly others:
1 - won't link(2) directories, which is documented in man 2 link and man 1 ln.
2 - won't link(2) symlinks which doesn't seem to be documented anywhere except
 the 'object' bits in man 7 symlink, paragraph 1.
 we've lchmod(2), lchown(2), lstat(2), lutimes(2) and no linksymlink(2) ;-]
3 - will link(2) everything else [regular, block, char, fifo, sock].

ok, part 2. this was going to be a second bug.
in 2.6.7 as released, and using --link-dest...
 these are hardlinked between --link-dest and destination:
  regular
  block
  char
 these are not hardlinked between --link-dest and destination:
  fifo
  sock
  slink
...which is today inconsistant since all but slinks can be hardlinked.

one point of --link-dest being to save tons of bytes on disk.
so this might be solved, with consistancy, by making it look like either...
 hardlinked:
  regular
 not hardlinked:
  block
  char
  fifo
  sock
  slink
...or...
 hardlinked:
  regular
  block
  char
  fifo
  sock
 not hardlinked:
  slink
... . expense of the calls to make the perm/uid/gid/mtime identical vs.
checking to see if they exist in --link-dest.

note that of course any hardlink relationships between inodes in the
source would still have to be mirrored in each destination and
--link-dest, just not between --link-dest and destination.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


More information about the rsync mailing list