Nulls instead of data

[Wojtek.Pilorz]

On Wed, 21 Sep 2005, Wayne Davison wrote:

> Date: Wed, 21 Sep 2005 10:06:07 -0700
> From: Wayne Davison <wayned at samba.org>
> To: Wojtek.Pilorz <wpilorz at bdk.pl>
> Cc: rsync at lists.samba.org
> Subject: Re: Nulls instead of data
> 
> On Wed, Sep 21, 2005 at 11:55:43AM +0200, Wojtek.Pilorz wrote:
> > After patching rsync with the patch provided, rsync did not quietly 
> > produced bad file, which is good, and, unfortunately, it did not produce 
> > any data, so there is still some room for improvement;
> 
> If you want the partial data saved (instead of discarded), specify
> --partial.  Otherwise, I don't see what else you expect rsync to do
> after getting an I/O read error on the source file.  
> 
> ..wayne..
> 
Hi,

I tried using  --partial and --partial-dir on that buggy link as follows:

[wp at pc2 transftest]$ mkdir partial
[wp at pc2 transftest]$ date; strace -tt -ff -o /mnt/extra4/wp/tmp/rsync266a_tr08.strace rsync266a -av -W --bwlimit=5 --partial --partial-dir partial/ /mnt/somedir/transftest/rsync-2.6.6.tar.gz  ./; date
Sat Sep 24 19:26:29 CEST 2005
Process 32214 attached
building file list ... done
Process 32215 attached
rsync-2.6.6.tar.gz
rsync: read errors mapping "/mnt/somedir/transftest/rsync-2.6.6.tar.gz": Input/output error (5)
WARNING: rsync-2.6.6.tar.gz failed verification -- update put into partial-dir (will try again).
rsync-2.6.6.tar.gz
rsync: read errors mapping "/mnt/somedir/transftest/rsync-2.6.6.tar.gz": Input/output error (5)
ERROR: rsync-2.6.6.tar.gz failed verification -- update put into partial-dir.
Process 32215 detached
Process 32214 detached

sent 1380476 bytes  received 65 bytes  2128.82 bytes/sec
total size is 690066  speedup is 0.50
rsync error: some files could not be transferred (code 23) at main.c(791)
Sat Sep 24 19:37:17 CEST 2005
[wp at pc2 transftest]$ date; strace -tt -ff -o /mnt/extra4/wp/tmp/rsync266a_tr09.strace rsync266a -av -W --bwlimit=5 --partial --partial-dir partial/ /mnt/somedir/transftest/rsync-2.6.6.tar.gz  ./; date
Sat Sep 24 19:45:30 CEST 2005
Process 32281 attached
building file list ... done
Process 32282 attached
rsync-2.6.6.tar.gz
rsync: read errors mapping "/mnt/somedir/transftest/rsync-2.6.6.tar.gz": Input/output error (5)
WARNING: rsync-2.6.6.tar.gz failed verification -- update put into partial-dir (will try again).
rsync-2.6.6.tar.gz
rsync: read errors mapping "/mnt/somedir/transftest/rsync-2.6.6.tar.gz": Input/output error (5)
ERROR: rsync-2.6.6.tar.gz failed verification -- update put into partial-dir.
Process 32282 detached
Process 32281 detached

sent 1380477 bytes  received 66 bytes  2043.74 bytes/sec
total size is 690066  speedup is 0.50
rsync error: some files could not be transferred (code 23) at main.c(791)
Sat Sep 24 19:56:45 CEST 2005


I save a copy of file put into partial as *.BAD2 and *.BAD3;
The files saved in partial directory have length equal to that of the original file,
but the contents still contains regions with NULLs (and somehow rsync does not like them):

[wp at pc2 transftest]$ xxd -g 1 -a partial/rsync-2.6.6.tar.gz.BAD2 | egrep -B 1 -A 2 '00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00'
004eff0: 9a 04 8d a8 52 95 d2 09 b6 bb e0 08 d2 39 34 6d  ....R........94m
004f000: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
*
0080000: ca 79 ee 3f 4a 57 0c 5b 21 9c fa e8 bd 77 aa 15  .y.?JW.[!....w..
--
0087ff0: cd bf 3d 2d 6a 1a 6a 16 81 50 d6 99 0b cc ea e5  ..=-j.j..P......
0088000: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
*
00a8790: 00 00                                            ..
[wp at pc2 transftest]$ xxd -g 1 -a partial/rsync-2.6.6.tar.gz.BAD3 | egrep -B 1 -A 2 '00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00'
0035ff0: a1 ef 9d 85 57 88 cf 7e 5d 93 7e 78 de 09 34 b4  ....W..~].~x..4.
0036000: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
*
0040000: 87 9f 7c 5e 14 0d 37 3c 93 06 00 e3 5b b4 29 d2  ..|^..7<....[.).
--
0053ff0: d6 1c d5 eb 71 77 00 e6 48 c4 d1 da 04 f7 7a b8  ....qw..H.....z.
0054000: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
*
0080000: c7 60 18 e6 0a 43 7e 6f c1 81 19 7a 4f d4 86 17  .`...C~o...zO...
--
008eff0: 27 68 c3 bc 56 e2 08 92 14 ad 2e 0a 68 c4 f0 b9  'h..V.......h...
008f000: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
*
00a8790: 00 00                                            ..


Should I send information from trace files?

Best regards,

Wojtek