[PATCH] fix read-batch SEGFAULT [WAS: --write-batch just hangs?]

[Jos Backus]

On Tue, May 04, 2004 at 08:14:22PM -0400, Chris Shoemaker wrote:
> Just so I'm on the right page, AFAICT, batch mode doesn't work _at all_.  

If that's the case, it could be that the batch mode code needs to be updated
to work with recent changes to rsync. Last time I tried running the tests
(which I posted to the list) it worked fine. I haven't had a chance to try it
lately though.

> If anyone knows differently, please let me know.  I've think I've tried 
> almost every possible test, including the one in the man page.  Anyway, 
> this patch does allow me to read a batch written locally.  That's a 
> start, at least.
> 
> Next, I'm going to see if I can figure out the hang that I mentioned 
> earlier...
 
Please keep us posted.

>   --Chris
>
> Index: generator.c
> ===================================================================
> RCS file: /cvsroot/rsync/generator.c,v
> retrieving revision 1.79
> diff -r1.79 generator.c
> 48a49
> > extern int read_batch;
> 216c217
> < 	if (whole_file == 0 || write_batch)
> ---
> > 	if (whole_file == 0 || write_batch || read_batch)

Interesting. I have the exact same patch sitting in my CVS tree but I can't
remember why it's there, sorry :-(

-- 
Jos Backus                       _/  _/_/_/      Sunnyvale, CA
                                _/  _/   _/
                               _/  _/_/_/
                          _/  _/  _/    _/
jos at catnook.com        _/_/   _/_/_/          require 'std/disclaimer'