[Bug 1463] poor performance with large block size

samba-bugs at samba.org samba-bugs at samba.org
Fri Jul 16 17:57:13 GMT 2004


https://bugzilla.samba.org/show_bug.cgi?id=1463


wayned at samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #543 is|0                           |1
           obsolete|                            |




------- Additional Comments From wayned at samba.org  2004-07-16 10:57 -------
Created an attachment (id=573)
 --> (https://bugzilla.samba.org/attachment.cgi?id=573&action=view)
Improved patch

I created a patch similar to Craig's that instead modifies the MAX_MAP_SIZE
value (using a new "max_map_size" variable) which is based on the current
file's block size.  This means that we get more consistent sizing (since "len"
can vary) and that the sequence of window_size checks works out as originally
intended (maxing out at either the end of the file or at offset + len,
whichever is greater).

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


More information about the rsync mailing list