[PATCH] Batch-mode rewrite
Chris Shoemaker
c.shoemaker at cox.net
Wed Jul 14 17:40:09 GMT 2004
There it goes...
On Wed, Jul 14, 2004 at 12:16:45AM -0700, Wayne Davison wrote:
> On Tue, Jul 13, 2004 at 04:40:39PM -0400, Chris Shoemaker wrote:
> > Do you see any reason to keep FIXED_CHECKSUM_SEED around? It doesn't
> > hurt anthing, but I don't see a use for it.
>
> You're right -- the new batchfile setup works fine without hard-wiring a
> checksum_seed value since the checksum is in the batchfile. It has even
> been suggested previously that a hard-wired value could be a bad thing
> in certain circumstances, so I'm all in favor of getting rid of it.
>
> ..wayne..
-------------- next part --------------
Index: options.c
===================================================================
RCS file: /cvsroot/rsync/options.c,v
retrieving revision 1.157
diff -u -r1.157 options.c
--- options.c 20 Jun 2004 19:47:05 -0000 1.157
+++ options.c 14 Jul 2004 22:27:59 -0000
@@ -133,7 +134,6 @@
int always_checksum = 0;
int list_only = 0;
-#define FIXED_CHECKSUM_SEED 32761
#define MAX_BATCH_PREFIX_LEN 256 /* Must be less than MAXPATHLEN-13 */
char *batch_prefix = NULL;
@@ -571,13 +571,11 @@
case OPT_WRITE_BATCH:
/* popt stores the filename in batch_prefix for us */
write_batch = 1;
- checksum_seed = FIXED_CHECKSUM_SEED;
break;
case OPT_READ_BATCH:
/* popt stores the filename in batch_prefix for us */
read_batch = 1;
- checksum_seed = FIXED_CHECKSUM_SEED;
break;
case OPT_TIMEOUT:
More information about the rsync
mailing list