[PATCH] Batch-mode rewrite

Wayne Davison wayned at samba.org
Tue Jul 13 00:05:52 GMT 2004


On Mon, Jul 12, 2004 at 02:47:30PM -0400, Chris Shoemaker wrote:
> On Mon, Jul 12, 2004 at 12:34:38PM -0700, Wayne Davison wrote:
> >     rsync -av --read-batch=foo localhost:/path/bar
> 
> Hmm, that case wasn't in my testing.  Did I introduce this limitation
> or has it always been so?

The old batch code only works with a local destination, so this isn't a
new limitation.  In fact, I think the old code fails in the same way as
the new, so this complaint should really just be a suggestion that the
code handle this better -- perhaps with a more direct complaint rather
than trying to write a file named "localhost:/path/bar" and failing.

However, it might be possible to change the way that the code is
handling the batch-read mode so that it could push a batch to a remote
host.  One way to do this is to drop the fd shuffle and instead keep
around a sender program that would enter a special loop where it did
nothing but dump data coming in from the generator while pushing batch
data down the socket/pipe to the receiver (this is quite a bit more
complicated than the current code, though, so feel free to leave this
out).

..wayne..


More information about the rsync mailing list