2.5.6pre1 bombs on Sunos4 in popthelp.c on use of sprintf
Albert Chin
rsync at lists.thewrittenword.com
Wed Jan 15 03:29:00 EST 2003
On Tue, Jan 14, 2003 at 03:28:04PM -0800, jw schultz wrote:
> On Tue, Jan 14, 2003 at 11:20:43AM -0600, Dave Dykstra wrote:
> > On Tue, Jan 14, 2003 at 10:24:04AM -0600, Dave Dykstra wrote:
> > > 2.5.6pre1 bombs on Sunos4 gcc with these errors
> > > popt/popthelp.c: In function `singleOptionDefaultValue':
> > > popt/popthelp.c:137: invalid operands to binary +
> > > popt/popthelp.c:141: invalid operands to binary +
> > > popt/popthelp.c:145: invalid operands to binary +
> > > popt/popthelp.c:149: invalid operands to binary +
> > > because it's depending on sprintf to return the number of bytes written
> > > and that doesn't happen on Sunos4.
> >
> > If nobody objects to the following patch, I'll put it in. It's a little
> > slower but this is definitely not time-critical code.
>
> It is a bit ugly but i don't have a problem with the
> performance here.
>
> I'd be concerned about someone not knowing about the Sunos4
> limitation messing with this though. At a minimum this
> needs comments. Even better would be if we can manage a way
> to conditionally have our own sprintf. I've a vague nagging
> that it can be done but can't recall how.
http://daniel.haxx.se/trio/
--
albert chin (china at thewrittenword.com)
More information about the rsync
mailing list