rsync-2.5.1 / popt patches

Martin Pool mbp at samba.org
Thu Jan 10 09:32:09 EST 2002


On  7 Jan 2002, "John E. Malmberg" <malmberg at Encompasserve.org> wrote:
> With the default warning level, some of the failures are silent, but can
> cause incorrect code to be generated.
> 
> In particular, malloc() will be substituted for the built in alloca()
> macro, unless Tru64 has the alloca.h header file.

That will cause a very minor memory leak, I think.  

> A cross platform product with multiple maintainers generally needs to have
> as high a warning level set as can be practically maintained.

I'd agree with that on the whole, so long as it doesn't require twisting the
code too much.

--
Martin




More information about the rsync mailing list