[linux-cifs-client] [PATCH 1/4] cifs: make cifs_lookup return a dentry

Jeff Layton jlayton at redhat.com
Sat May 22 08:08:36 MDT 2010


On Sat, 22 May 2010 14:30:51 +0100
Al Viro <viro at ZenIV.linux.org.uk> wrote:

> On Fri, May 21, 2010 at 02:25:14PM -0400, Jeff Layton wrote:
> > cifs_lookup doesn't actually return a dentry. It instantiates the one
> > that's passed in, but callers don't have any way to know if the lookup
> > succeeded.
> 
> Huh?  Of course they do - ->lookup() has every right to do just that;
> d_add() and return NULL is perfectly legitimate.

OK, bad description on my part... Is one way of doing this preferred
over another?

-- 
Jeff Layton <jlayton at redhat.com>


More information about the linux-cifs-client mailing list