[linux-cifs-client] linux-next: build warning after merge of the cifs tree

Stephen Rothwell sfr at canb.auug.org.au
Wed Mar 31 18:51:12 MDT 2010


Hi Steve,

After merging the cifs tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

fs/cifs/cifssmb.c: In function 'CIFSSMBWrite':
fs/cifs/cifssmb.c:1516: warning: suggest explicit braces to avoid ambiguous 'else'

Introduced by commit 5702f749ee6645f70412cfe6408503a735366ffe ("cifs:
initialize nbytes at the beginning of CIFSSMBWrite()").

The cFYI() macro that is invoked in the (unbraced) if clause contains an
if statement ...  so this warning actually indicates a bug.  Those
debugging macros look like a real mess ...

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/linux-cifs-client/attachments/20100401/eb0e0ad5/attachment-0001.pgp>


More information about the linux-cifs-client mailing list