[linux-cifs-client] Re: [PATCH] [CIFS] fix inode leak in cifs_get_inode_info_unix

[Andrew Morton]

On Wed, 02 Jul 2008 05:57:38 -0400 Jeff Layton <jlayton at redhat.com> wrote:

> Date: 	Wed, 02 Jul 2008 05:57:38 -0400

hm, nine days and afaict this post-2.6.25 regression remains unfixed?

> Sender: linux-kernel-owner at vger.kernel.org
> User-Agent: StGIT/0.14.2
> 
> Try this:
> 
>     mount a share with unix extensions
>     create a file on it
>     umount the share
> 
> You'll get the following message in the ring buffer:
> 
> VFS: Busy inodes after unmount of cifs. Self-destruct in 5 seconds.  Have a
> nice day...
> 
> ...the problem is that cifs_get_inode_info_unix is creating and hashing
> a new inode even when it's going to return error anyway. The first
> lookup when creating a file returns an error so we end up leaking this
> inode before we do the actual create. This appears to be a regression
> caused by commit 0e4bbde94fdc33f5b3d793166b21bf768ca3e098.
> 
> The following patch seems to fix it for me, and fixes a minor
> formatting nit as well.
> 
> Signed-off-by: Jeff Layton <jlayton at redhat.com>

So it's probably too late to get this into 2.6.26.  I'll merge it with
a cc:stable and hopefully 2.6.26.1 will not have this bug.

I'll give "fix wksidarr declaration to be big-endian friendly" the same
treatment.